lkml.org 
[lkml]   [2013]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/10] sched, fair: Fix the sd_parent_degenerate() code
On Sat, Aug 24, 2013 at 03:45:57AM -0700, Paul Turner wrote:
> > @@ -5157,6 +5158,13 @@ cpu_attach_domain(struct sched_domain *s
> > tmp->parent = parent->parent;
> > if (parent->parent)
> > parent->parent->child = tmp;
> > + /*
> > + * Transfer SD_PREFER_SIBLING down in case of a
> > + * degenerate parent; the spans match for this
> > + * so the property transfers.
> > + */
> > + if (parent->flags & SD_PREFER_SIBLING)
> > + tmp->flags |= SD_PREFER_SIBLING;
> > destroy_sched_domain(parent, cpu);
> > } else
> > tmp = tmp->parent;
> >
>
> Reviewed-by: Paul Turner <pjt@google.com>

BTW, did that comment make sense to you or would you suggest something
different? I had/am having a hard time with that comment. Somehow it
leaves me wanting. I know I understand the issue now, but I'll doubt the
comment will suffice in a years time :/


\
 
 \ /
  Last update: 2013-08-26 14:21    [W:0.302 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site