Messages in this thread | | | Date | Mon, 26 Aug 2013 13:27:37 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 03/18] asymmetric keys: separate the length checking of octet string from RSA_I2OSP |
| |
Hi!
> > > Due to RSA_I2OSP is not only used by signature verification path but also used > > > in signature generation path. So, separate the length checking of octet string > > > because it's not for generate 0x00 0x01 leading string when used in signature > > > generation. > > > > > > Reviewed-by: Jiri Kosina <jkosina@suse.cz> > > > Signed-off-by: Lee, Chun-Yi <jlee@suse.com> > > > > > +static int RSA_I2OSP(MPI x, size_t xLen, u8 **_X) > > > +{ > > > + unsigned x_size; > > > + unsigned X_size; > > > + u8 *X = NULL; > > > > Is this kernel code or entry into obfuscated C code contest? This is not funny. > > > The small "x" is the input integer that will transfer to big "X" that is > a octet sting. > > Sorry for I direct give variable name to match with spec, maybe I need > use big_X or....
Having variables that differ only in case is confusing. Actually RSA_I2OSP is not a good name for function, either.
If it converts x into X, perhaps you can name one input and second output?
> Do you have good suggest for the naming?
Not really, sorry. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |