lkml.org 
[lkml]   [2013]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC 17/17] clk: zynq: remove call to of_clk_init
    Hi Sebastian,

    On Tue, Aug 20, 2013 at 04:04:31AM +0200, Sebastian Hesselbarth wrote:
    > With arch/arm calling of_clk_init(NULL) from time_init(), we can now
    > remove it from corresponding drivers/clk code.

    I think that would break Zynq.
    If I see this correctly you call of_clk_init() from common code,
    _before_ the SOC specific time init function is called.
    The problem is, that we have code setting up a global pointer which is
    required by zynq_clk_setup() which is triggered when of_clk_init() is
    called.

    Let me try to illustrate the current call graph:

    time_init()
    zynq_timer_init() // this machines init_time()
    zynq_slcr_init() // setup System Level Control Registers including a global pointer
    zynq_clock_init()
    of_clk_init()
    zynq_clk_setup() // requires pointer setup in zynq_slcr_init()
    ...

    IIUC, your series would change this to:
    time_init()
    of_clk_init()
    zynq_clk_setup() // SLCR pointer is not setup/NULL
    ...
    zynq_timer_init()
    zynq_slcr_init() // now the pointer becomes valid

    Sören


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-08-23 02:41    [W:5.027 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site