Messages in this thread | | | Date | Fri, 02 Aug 2013 09:39:49 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v7] watchdog: Add MOXA ART watchdog driver |
| |
On 08/02/2013 04:41 AM, Mark Rutland wrote: > On Mon, Jul 29, 2013 at 01:33:48PM +0100, Jonas Jensen wrote: >> Add watchdog driver for MOXA ART SoCs. >> [ ... ] >> + >> + err = watchdog_register_device(&moxart_wdt->dev); >> + if (unlikely(err)) >> + return err; > > This is a probe path. Is the use of unlikely() really appropriate here? > I suspect it doesn't make any appreciable difference, and should go. > Just wondering, for my education - why ? Is there s rule that unlikely() shall not be used in the probe path ? If so, I would like to know it and its reasoning to be able to apply it to my own reviews.
Thanks, Guenter
| |