Messages in this thread | | | Date | Thu, 15 Aug 2013 20:05:21 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v3 3/3] sched: clean-up struct sd_lb_stat |
| |
On Tue, Aug 06, 2013 at 05:36:43PM +0900, Joonsoo Kim wrote: > - if (sds->group_imb) { > - sds->busiest_load_per_task = > - min(sds->busiest_load_per_task, sds->avg_load);
> + if (busiest->group_imb) { > + busiest->load_per_task = > + min(busiest->load_per_task, sds->sd_avg_load); > }
> - if (sds->max_load < sds->avg_load) { > + if (busiest->avg_load < this->avg_load) {
Tsk, inconsistency there.
> - max_pull = min(sds->max_load - sds->avg_load, load_above_capacity); > + max_pull = min(busiest->avg_load - sds->sd_avg_load, > + load_above_capacity);
you just made it possible for the above subtraction to become negative.
Also not entirely sure why you renamed sds->avg_load; renaming it back.
| |