Messages in this thread | | | Date | Tue, 13 Aug 2013 20:25:18 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 2/4] perf, x86: Report TSX transaction abort cost as weight |
| |
> Make it a bigger mess: :-)
Ok. Only the second union is enough, it only needs the flags, not the cycles.
> > struct hsw_tsx_abort_info { > union { > u64 value; > struct { > u32 cycles_last_tx; > union { > }; > > Also, I think your patch is 'broken' in that it dumps the reserved bits > out to userspace and this brand spanking new SDM doesn't say they're 0.
Will fix.
> __intel_pmu_pebs_event() isn't getting any prettier with all those > pebs_format tests; but I'm not seeing anything to really fix that.
Ok. Are you merging your patch with these changes (fll, union) or should I send a new one?
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |