lkml.org 
[lkml]   [2013]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.
From
Hi Linus,

On Tue, Jul 30, 2013 at 12:47 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> On Fri, Jul 26, 2013 at 6:57 AM, Sonic Zhang <sonic.adi@gmail.com> wrote:
>
>> Could you please comment on this patch set? It is based on your former comments.
>
> I'll get to it. I'm pretty choked right now and actually trying to have
> some vacation at the same time.
>
> In the meantime, after glancing over and noting prolific use of the
> unlikely() macro, please read the following articles:
> http://lwn.net/Articles/70473/
> http://lwn.net/Articles/420019/
>

These articles say the directives should be rarely used. Do you
suggest to remove them from the patch?

Regards,

Sonic


\
 
 \ /
  Last update: 2013-08-01 10:01    [W:0.062 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site