lkml.org 
[lkml]   [2013]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] acpi: video: remove unnecessary casting
    On 08/02/2013 07:44 AM, Felipe Contreras wrote:
    > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>

    Looks good to me, except that no change log feels a little weird.

    Reviewed-by: Aaron Lu <aaron.lu@intel.com>

    Thanks,
    Aaron

    > ---
    > drivers/acpi/video.c | 6 ++----
    > 1 file changed, 2 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
    > index b07573f..11bafbe 100644
    > --- a/drivers/acpi/video.c
    > +++ b/drivers/acpi/video.c
    > @@ -236,8 +236,7 @@ static int acpi_video_get_brightness(struct backlight_device *bd)
    > {
    > unsigned long long cur_level;
    > int i;
    > - struct acpi_video_device *vd =
    > - (struct acpi_video_device *)bl_get_data(bd);
    > + struct acpi_video_device *vd = bl_get_data(bd);
    >
    > if (acpi_video_device_lcd_get_level_current(vd, &cur_level, false))
    > return -EINVAL;
    > @@ -255,8 +254,7 @@ static int acpi_video_get_brightness(struct backlight_device *bd)
    > static int acpi_video_set_brightness(struct backlight_device *bd)
    > {
    > int request_level = bd->props.brightness + 2;
    > - struct acpi_video_device *vd =
    > - (struct acpi_video_device *)bl_get_data(bd);
    > + struct acpi_video_device *vd = bl_get_data(bd);
    >
    > return acpi_video_device_lcd_set_level(vd,
    > vd->brightness->levels[request_level]);
    >



    \
     
     \ /
      Last update: 2013-08-02 04:21    [W:2.379 / U:0.800 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site