Messages in this thread | | | Subject | Re: [PATCH 1/2] aoe: remove custom implementation of kbasename() | From | Ed Cashin <> | Date | Thu, 1 Aug 2013 21:04:36 -0400 |
| |
Looks OK. Thanks.
On Aug 1, 2013, at 8:28 AM, Andy Shevchenko wrote:
> In the kernel we have a nice helper that may be used here. This patch > substitutes the custom implementation by the native function call. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/block/aoe/aoedev.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c > index 784c92e..db35ef6 100644 > --- a/drivers/block/aoe/aoedev.c > +++ b/drivers/block/aoe/aoedev.c > @@ -12,6 +12,7 @@ > #include <linux/bitmap.h> > #include <linux/kdev_t.h> > #include <linux/moduleparam.h> > +#include <linux/string.h> > #include "aoe.h" > > static void dummy_timer(ulong); > @@ -241,16 +242,12 @@ aoedev_downdev(struct aoedev *d) > static int > user_req(char *s, size_t slen, struct aoedev *d) > { > - char *p; > + const char *p; > size_t lim; > > if (!d->gd) > return 0; > - p = strrchr(d->gd->disk_name, '/'); > - if (!p) > - p = d->gd->disk_name; > - else > - p += 1; > + p = kbasename(d->gd->disk_name); > lim = sizeof(d->gd->disk_name); > lim -= p - d->gd->disk_name; > if (slen < lim) > -- > 1.8.3.2 >
-- Ed Cashin ecashin@coraid.com
| |