Messages in this thread | | | Date | Fri, 2 Aug 2013 06:28:40 +0800 | From | Greg KH <> | Subject | Re: [PATCH] Staging: wlags49_h2: fixed 80 line character and white space issue in ap_h2.c Fixed various coding style warnings found by the checkpatch.pl tool |
| |
On Thu, Aug 01, 2013 at 03:08:21PM -0700, Evan Ng wrote: > Thanks for the reply, > > Being this is my first patch that I have submitted, I want to clarify a few > things: > > My *corrected* subject should read something like this? > > "Subject: [PATCH] Staging: wlags49_h2: fixed 80 line character and white space > issue in ap_h2.c Fixed various coding style warnings found by > the > checkpatch.pl tool > \n > LONGER DESCRIPTION GOES HERE"
No.
It should be: Subject: [PATCH] Staging: wlags48_h2: ap_h2.c: fixed tab whitespace issue
This patch fixes the tab vs. spaces white space issues in this file.
Signed-off-by: ....
> As for the doing "one thing at a time" would it be preferred if I fix the > syntax of one function within a file a time? Would that mean that for one > simple .c file I could be making 15 or so commits to it?
How about fixing one specific warning at a time for the whole file? Like tab issues, and then { issues, and then ' ' issues, and so on. See the archives of the mailing list for lots of examples of how to do this properly.
hope this helps,
greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |