Messages in this thread | | | Date | Thu, 01 Aug 2013 11:31:00 -0700 (PDT) | Subject | Re: [PATCH v2 13/12] tile: set hw_features and vlan_features in setup | From | David Miller <> |
| |
From: Chris Metcalf <cmetcalf@tilera.com> Date: Thu, 1 Aug 2013 11:36:42 -0400
> This change allows the user to configure various features of the tile > networking drivers on and off. There is no change to the default > initialization state of either the tilegx or tilepro drivers. > > Neither driver needs the ndo_fix_features or ndo_set_features callbacks, > since the generic code already handles the dependencies for > fix_features, and there is no hardware state to tweak in set_features. > > Signed-off-by: Chris Metcalf <cmetcalf@tilera.com> > --- > David, I've fixed the drivers to use hw_features as a follow-on "13 of > 12" patch in the v2 series, rather than rebasing the previous patches, > since they weren't actually buggy as-is, and this was simpler. However, > I am happy to provide a v3 of the patch series with the hw_features > change rebased to the front if that feels better to you.
Please redo your patch series properly rather than appending fixes on top, thank you.
| |