Messages in this thread | | | Date | Thu, 01 Aug 2013 10:44:06 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH V2] drivers/rtc/rtc-palmas.c: support for backup battery charging |
| |
On 08/01/2013 08:31 AM, Laxman Dewangan wrote: > Palmas series device like TPS65913, TPS80036 supports the backup battery > for powering the RTC when no other energy source is available. > > The backup battery is optional, connected to the VBACKUP pin, and can be > nonrechargeable or rechargeable. The rechargeable battery can be charged > from the system supply using the backup battery charger. > > Add support for enabling charging of this backup battery. Also add the DT > binding document and the new properties to have this support.
> diff --git a/Documentation/devicetree/bindings/rtc/rtc-palmas.txt b/Documentation/devicetree/bindings/rtc/rtc-palmas.txt
> +Palmas RTC controller bindings > + > +Required properties: > +- compatible: > + - "ti,palmas-rtc" for palma series of the RTC controller
Nit: Here is another Palma -vs- Palmas inconsistency. What is the correct name for the device; Palma or Palmas? Either way, the should always have an initial capital letter in free-form text (i.e. but not in property/node names).
Aside from that, the binding looks fine to me now, assuming it's fully describing the RTC module's functionality. So, the binding,
Reviewed-by: Stephen Warren <swarren@nvidia.com>
| |