lkml.org 
[lkml]   [2013]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] USB: ohci-at91: add usb_clk for transition to common clk framework
On Thu, 1 Aug 2013, boris brezillon wrote:

> > What happens if uclk isn't found but it is needed?
> It will not fail but I guess the usb host won't work as the clock won't
> be correctly
> configured.
>
> I agree with you: this is not a good solution.
>
> Another option is to keep the previous version of this patch and put
> uclk handling
> in "#ifdef CONFIG_COMMON_CLK #endif" sections.
>
> Would this be acceptable ?

Yes. However, a more elegant approach is to protect the relevant
statements with: if (defined(CONFIG_COMMON_CLK)). This preprocessor
evaluates this to a 0 or 1, so the compiler will not generate output
for the protected source code if the symbol isn't defined.

Alan Stern



\
 
 \ /
  Last update: 2013-08-01 18:41    [W:0.053 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site