Messages in this thread | | | From | KY Srinivasan <> | Subject | RE: [PATCH] Tools: hv: check return value of system in hv_kvp_daemon | Date | Thu, 1 Aug 2013 14:36:10 +0000 |
| |
> -----Original Message----- > From: Olaf Hering [mailto:olaf@aepfle.de] > Sent: Thursday, August 01, 2013 9:04 AM > To: KY Srinivasan; gregkh@linuxfoundation.org > Cc: linux-kernel@vger.kernel.org; Olaf Hering > Subject: [PATCH] Tools: hv: check return value of system in hv_kvp_daemon > > hv_kvp_daemon.c: In function 'main': > hv_kvp_daemon.c:1441:8: warning: ignoring return value of 'daemon', declared > with attribute warn_unused_result [-Wunused-result] > > Signed-off-by: Olaf Hering <olaf@aepfle.de> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> > --- > tools/hv/hv_kvp_daemon.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c > index ba075e5..b96eccc 100644 > --- a/tools/hv/hv_kvp_daemon.c > +++ b/tools/hv/hv_kvp_daemon.c > @@ -1353,7 +1353,11 @@ setval_done: > */ > > snprintf(cmd, sizeof(cmd), "%s %s", "hv_set_ifconfig", if_file); > - system(cmd); > + if (system(cmd)) { > + syslog(LOG_ERR, "Failed to execute cmd '%s'; error: %d %s", > + cmd, errno, strerror(errno)); > + return HV_E_FAIL; > + } > return 0; > > setval_error: > >
| |