Messages in this thread | | | Date | Thu, 1 Aug 2013 17:45:28 +0300 | From | "Michael S. Tsirkin" <> | Subject | Re: [PATCH] macvlan: validate flags |
| |
On Thu, Aug 01, 2013 at 06:36:05PM +0400, Sergei Shtylyov wrote: > Hello. > > On 01-08-2013 14:48, Michael S. Tsirkin wrote: > > >commit df8ef8f3aaa6692970a436204c4429210addb23a > > Please also specify that commit's summary line in parens. > This is the only way to uniquely identify the commit, and it's the > requirement that came originally from Linus AFAIK.
Ouch, no idea why do I keep making this mistake. Will do, thanks.
> >added a flags field to macvlan, which can be > >controlled from userspace. > >The idea is to make the interface future-proof > >so we can add flags and not new fields. > > >However, flags value isn't validated, as a result, > >userspace can't detect which flags are supported. > > >Cc: "David S. Miller" <davem@davemloft.net> > >CC: Roopa Prabhu <roprabhu@cisco.com> > >Cc: John Fastabend <john.r.fastabend@intel.com> > >Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > WBR, Sergei
| |