Messages in this thread | | | From | KY Srinivasan <> | Subject | RE: [PATCH] Tools: hv: in kvp_set_ip_info free mac_addr right after usage | Date | Thu, 1 Aug 2013 14:35:36 +0000 |
| |
> -----Original Message----- > From: Olaf Hering [mailto:olaf@aepfle.de] > Sent: Thursday, August 01, 2013 8:58 AM > To: KY Srinivasan; gregkh@linuxfoundation.org > Cc: linux-kernel@vger.kernel.org; Olaf Hering > Subject: [PATCH] Tools: hv: in kvp_set_ip_info free mac_addr right after usage > > ... to simplify error path in upcoming changes. > > Signed-off-by: Olaf Hering <olaf@aepfle.de> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> > --- > tools/hv/hv_kvp_daemon.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c > index 418ac55..ba075e5 100644 > --- a/tools/hv/hv_kvp_daemon.c > +++ b/tools/hv/hv_kvp_daemon.c > @@ -1299,6 +1299,7 @@ static int kvp_set_ip_info(char *if_name, struct > hv_kvp_ipaddr_value *new_val) > } > > error = kvp_write_file(file, "HWADDR", "", mac_addr); > + free(mac_addr); > if (error) > goto setval_error; > > @@ -1344,7 +1345,6 @@ static int kvp_set_ip_info(char *if_name, struct > hv_kvp_ipaddr_value *new_val) > goto setval_error; > > setval_done: > - free(mac_addr); > fclose(file); > > /* > @@ -1358,7 +1358,6 @@ setval_done: > > setval_error: > syslog(LOG_ERR, "Failed to write config file"); > - free(mac_addr); > fclose(file); > return error; > } > >
| |