Messages in this thread | | | Date | Thu, 1 Aug 2013 11:12:38 +0100 | From | David Vrabel <> | Subject | Re: [PATCH 1/3] xen-gnt: prevent adding duplicate gnt callbacks |
| |
On 31/07/13 16:00, Roger Pau Monne wrote: > With the current implementation, the callback in the tail of the list > can be added twice, because the check done in > gnttab_request_free_callback is bogus, callback->next can be NULL if > it is the last callback in the list. If we add the same callback twice > we end up with an infinite loop, were callback == callback->next. > > Replace this check with a proper one that iterates over the list to > see if the callback has already been added.
As a minimal fix suitable for stable,
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
David
| |