| Date | Tue, 9 Jul 2013 22:17:51 +0100 | Subject | Re: [PATCH 2/5] mmc: dw_mmc: Add suspend/resume callbacks; disable irq during suspend | From | James Hogan <> |
| |
Hi Doug,
On 9 July 2013 18:31, Doug Anderson <dianders@chromium.org> wrote: > On some platforms (like exynos5420) the dw_mmc controller may be in a > strange state after we wake up from sleep. Add callbacks to allow for > dealing with these quirks. Prevent interrupts from firing when we're > suspended since this strange state may cause interrupts to fire. > > In my case I saw the WAKEUP_INT interrupt firing upon resume and > needed to add some code to handle this. > > Signed-off-by: Doug Anderson <dianders@chromium.org>
Would it make sense to take advantage of the {suspend,resume}_noirq power management callbacks to clear that WAKEUP_INT before interrupts are re-enabled, rather than explicitly disabling and enabling the interrupt at the suspend/resume stage?
Cheers James
|