Messages in this thread | | | Date | Tue, 9 Jul 2013 10:07:45 +0200 | From | Peter Zijlstra <> | Subject | Re: [RFC PATCH] tracing/kprobe: Wait for disabling all running kprobe handlers |
| |
On Tue, Jul 09, 2013 at 05:01:45PM +0900, Masami Hiramatsu wrote: > + if (wait) { > + /* > + * synchronize with kprobe_trace_func/kretprobe_trace_func > + * to ensure disabled (all running handlers are finished) > + */ > + synchronize_sched(); > + kfree(link); /* Ignored if link == NULL */ > + }
What's not clear to me from this comment is if we're only waiting for kfree()? In that case shouldn't we use call_rcu() to free the thing? Or do we need the sync_sched() for other purposes as well?
| |