Messages in this thread Patch in this message | | | Date | Tue, 09 Jul 2013 11:37:59 +0800 | From | Chen Gang <> | Subject | [PATCH] kernel/params.c: print failure information instead of 'KOBJ_ADD' to user space, when sysfs_create_file() fails. |
| |
When sysfs_create_file() fails, recommend to print the related failure information. And it is useless to still 'KOBJ_ADD' to user space.
Signed-off-by: Chen Gang <gang.chen@asianux.com> --- kernel/params.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/kernel/params.c b/kernel/params.c index 440e65d..f5299c1 100644 --- a/kernel/params.c +++ b/kernel/params.c @@ -845,7 +845,13 @@ static void __init version_sysfs_builtin(void) mk = locate_module_kobject(vattr->module_name); if (mk) { err = sysfs_create_file(&mk->kobj, &vattr->mattr.attr); - kobject_uevent(&mk->kobj, KOBJ_ADD); + if (err) + printk(KERN_WARNING + "%s (%d): sysfs_create_file fail for %s, err: %d\n", + __FILE__, __LINE__, + vattr->module_name, err); + else + kobject_uevent(&mk->kobj, KOBJ_ADD); kobject_put(&mk->kobj); } } -- 1.7.7.6
| |