Messages in this thread | | | Date | Mon, 8 Jul 2013 12:34:59 -0700 | From | Matt Wilson <> | Subject | Re: [Xen-devel] [PATCH] xen: remove unused Kconfig parameter |
| |
On Mon, Jul 08, 2013 at 03:28:54PM -0400, Konrad Rzeszutek Wilk wrote: > On Mon, Jul 08, 2013 at 08:28:24AM +0200, Michael Opdenacker wrote: > > This patch proposes to remove the XEN_PRIVILEGED_GUEST kernel > > configuration parameter defined in arch/x86/xen/Kconfig, but used > > nowhere in the makefiles and source code. > > > > This dummy parameter was added 3 years back, and it may > > make sense to remove it now, as the reasons to use it were not > > very clear. > > > > Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com> > > Can't remove it. It is used by grub2.
For reference, here's a related Debian bug report: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=633127
Summary: grub2 scripts parse /boot/config-$(uname -r)
--msw
> > --- > > arch/x86/xen/Kconfig | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig > > index 1a3c765..b6401dc 100644 > > --- a/arch/x86/xen/Kconfig > > +++ b/arch/x86/xen/Kconfig > > @@ -19,11 +19,6 @@ config XEN_DOM0 > > depends on XEN && PCI_XEN && SWIOTLB_XEN > > depends on X86_LOCAL_APIC && X86_IO_APIC && ACPI && PCI > > > > -# Dummy symbol since people have come to rely on the PRIVILEGED_GUEST > > -# name in tools. > > -config XEN_PRIVILEGED_GUEST > > - def_bool XEN_DOM0 > > - > > config XEN_PVHVM > > def_bool y > > depends on XEN && PCI && X86_LOCAL_APIC > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel
| |