lkml.org 
[lkml]   [2013]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH V4 14/21] perf tools: change "machine" functions to set thread pid
On 7/4/13 7:20 AM, Adrian Hunter wrote:
> Typically tracking events such as mmap events, comm events,
> fork events and exit events, are processed by "machine"
> functions. Change these functions to put pid in the new
> pid_ member of struct thread.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/util/machine.c | 21 +++++++++++++++++----
> tools/perf/util/machine.h | 2 ++
> 2 files changed, 19 insertions(+), 4 deletions(-)
>

---8<---

> diff --git a/tools/perf/util/machine.h b/tools/perf/util/machine.h
> index e49ba01..d986ecf 100644
> --- a/tools/perf/util/machine.h
> +++ b/tools/perf/util/machine.h
> @@ -100,6 +100,8 @@ static inline bool machine__is_host(struct machine *machine)
> }
>
> struct thread *machine__findnew_thread(struct machine *machine, pid_t tid);
> +struct thread *machine__findnew_thread_ex(struct machine *machine, pid_t pid,
> + pid_t tid);
>
> size_t machine__fprintf(struct machine *machine, FILE *fp);
>
>


Why do you want to add a new API for this? Why not just fix
findnew_thread and find_thread to take the pid argument? We don't need 2
apis that do the same thing.

David


\
 
 \ /
  Last update: 2013-07-06 18:21    [W:1.268 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site