lkml.org 
[lkml]   [2013]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: MTD EEPROM support and driver integration
Date
On Saturday 06 July 2013 10:28:04 Maxime Ripard wrote:
> > a) like interrupts, regs, dmas, clocks, pinctrl, reset, pwm: fixed property names
> >
> > regmap = <&at25 0xstart 0xlen>;
> > regmap-names = "mac-address";
> >
> > b) like gpio, regulator: variable property names
> >
> > mac-storage = <&at25 0xstart 0xlen>;
> >
> > It's unfortunate that we already have examples of both. They are largely
> > equivalent, but the tendency is towards the first.
>
> I don't have a strong feeling for one against another, so whatever works
> best. Both solutions will be a huge improvement anyway
>
> Just out of curiosity, is there any advantages besides having a fixed
> property name to the first solution?

I think it's mostly for consistency: trying to get most subsystems to
do it the same way to make it easier for people to write dts files.

A lesser point is that it simplifies the driver code if you don't
have to pass a name.


Arnd


\
 
 \ /
  Last update: 2013-07-06 12:01    [W:0.538 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site