Messages in this thread | | | Date | Fri, 5 Jul 2013 12:15:49 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH v2] dma: mmp_pdma: fix a memory alloc error |
| |
On Tue, Jun 18, 2013 at 02:21:58PM +0800, Xiang Wang wrote: > From: Xiang Wang <wangx@marvell.com> > > pdev->phy is of type "struct mmp_pdma_phy *". But when > allocating memory for it, "struct mmp_pdma_chan" is used > by mistake. > > Signed-off-by: Xiang Wang <wangx@marvell.com> > --- > drivers/dma/mmp_pdma.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c > index c26699f..18ac57f 100644 > --- a/drivers/dma/mmp_pdma.c > +++ b/drivers/dma/mmp_pdma.c > @@ -801,7 +801,7 @@ static int mmp_pdma_probe(struct platform_device *op) > } > > pdev->phy = devm_kzalloc(pdev->dev, > - dma_channels * sizeof(struct mmp_pdma_chan), GFP_KERNEL); > + dma_channels * sizeof(*pdev->phy), GFP_KERNEL); While at it, can you make the flag GFP_NOWAIT. that is the recommendation for dmac drivers
-- ~Vinod
| |