lkml.org 
[lkml]   [2013]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCHv4 00/10] clocksource: sunxi: Timer fixes and cleanup
    Date
    Hi everyone,

    The first timer code we merged when adding support for the A13 some
    time back was mostly a clean up from the source drop we had, without
    any documentation. This happened to work, but the code merged in
    turned out to be far from perfect, and had several flaws.

    This patchset hopefully fixes these flaws, and cleanup most of the
    driver as well, to end up in an almost complete rewrite of it (even
    though it's not that long).

    It also finally adds a clocksource driver using the second timer as
    our monotonic clock source.

    These flaws have all been spotted when trying to add the A31 support,
    work that is still ongoing, but will hopefully benefit from this
    patchset as well.

    Thanks,
    Maxime

    Changes from v3:
    - Reintroduce the rate variable to cache the parent clock rate
    - Remove the interval programming at probe time that was
    reintroduced in the v3 due to a poor rebase.

    Changes from v2:
    - Use the clocksource timer to get the amount of time we have to
    wait for when disabling and enabling back a timer
    - Added patch to add parenthesis around the macros arguments
    - Renamed the AUTORELOAD register define to the more meaningful
    RELOAD name

    Changes from v1:
    - Rebased on top of linux-next to benefit from the move to all
    architectures of the sched_clock functions
    - Moved the clock source to the second timer instead of the 64 bits
    free-running counter like suggested by Thomas.

    Maxime Ripard (10):
    clocksource: sun4i: Use the BIT macros where possible
    clocksource: sun4i: Wrap macros arguments in parenthesis
    clocksource: sun4i: rename AUTORELOAD define to RELOAD
    clocksource: sun4i: Add clocksource and sched clock drivers
    clocksource: sun4i: Don't forget to enable the clock we use
    clocksource: sun4i: Fix the next event code
    clocksource: sun4i: Factor out some timer code
    clocksource: sun4i: Remove TIMER_SCAL variable
    clocksource: sun4i: Cleanup parent clock setup
    clocksource: sun4i: Fix bug when switching from periodic to oneshot
    modes

    drivers/clocksource/sun4i_timer.c | 110 +++++++++++++++++++++++++++-----------
    1 file changed, 78 insertions(+), 32 deletions(-)

    --
    1.8.3.2



    \
     
     \ /
      Last update: 2013-07-06 00:41    [W:2.196 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site