Messages in this thread | | | Subject | Re: [PATCH v3 1/6] misc: sram: fix error path in sram_probe | From | Philipp Zabel <> | Date | Fri, 05 Jul 2013 16:23:23 +0200 |
| |
Am Freitag, den 05.07.2013, 14:40 +0200 schrieb Heiko Stübner: > The pool is created thru devm_gen_pool_create, so the call to > gen_pool_destroy is not necessary. > Instead the sram-clock must be turned off again if it exists. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > Tested-by: Ulrich Prinz <ulrich.prinz@googlemail.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> --- > drivers/misc/sram.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c > index d87cc91..afe66571 100644 > --- a/drivers/misc/sram.c > +++ b/drivers/misc/sram.c > @@ -68,7 +68,8 @@ static int sram_probe(struct platform_device *pdev) > ret = gen_pool_add_virt(sram->pool, (unsigned long)virt_base, > res->start, size, -1); > if (ret < 0) { > - gen_pool_destroy(sram->pool); > + if (sram->clk) > + clk_disable_unprepare(sram->clk); > return ret; > } >
regards Philipp
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |