lkml.org 
[lkml]   [2013]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] irqchip: vt8500: Staticize local symbols
On 04/07/13 18:11, Axel Lin wrote:
> This driver is converted to use IRQCHIP_DECLARE and irqchip_init.
> vt8500_handle_irq() and vt8500_irq_init() are only referenced in this file now,
> make them static.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/irqchip/irq-vt8500.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-vt8500.c b/drivers/irqchip/irq-vt8500.c
> index d970595..1846e7d 100644
> --- a/drivers/irqchip/irq-vt8500.c
> +++ b/drivers/irqchip/irq-vt8500.c
> @@ -178,7 +178,8 @@ static struct irq_domain_ops vt8500_irq_domain_ops = {
> .xlate = irq_domain_xlate_onecell,
> };
>
> -asmlinkage void __exception_irq_entry vt8500_handle_irq(struct pt_regs *regs)
> +static asmlinkage
> +void __exception_irq_entry vt8500_handle_irq(struct pt_regs *regs)
> {
> u32 stat, i;
> int irqnr, virq;
> @@ -203,7 +204,8 @@ asmlinkage void __exception_irq_entry vt8500_handle_irq(struct pt_regs *regs)
> }
> }
>
> -int __init vt8500_irq_init(struct device_node *node, struct device_node *parent)
> +static int __init vt8500_irq_init(struct device_node *node,
> + struct device_node *parent)
I prefer that the function variables are lined up, rather than aligning
with the (. Can you move the 'struct device_node *parent' across one
more space?

Otherwise:

Acked-by: Tony Prisk <linux@prisktech.co.nz>
> {
> int irq, i;
> struct device_node *np = node;

Regards
Tony P


\
 
 \ /
  Last update: 2013-07-04 21:01    [W:0.207 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site