Messages in this thread | | | Date | Thu, 4 Jul 2013 15:51:26 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 3/4] mfd: s2mps11: Add device tree support |
| |
On Thu, Jul 04, 2013 at 05:13:46PM +0530, Yadwinder Singh Brar wrote: > On Thu, Jul 4, 2013 at 2:52 PM, Mark Brown <broonie@kernel.org> wrote:
> > That's just an issue in the code if that is the case, you can test for > > the presence of a property independently of getting its value.
> Yes, for that we will need an extra flag (ramp_disable) in > constraints, to figure out whether > ramp-rate is actually set to zero or its left (by default) zero if we > do it in common code as > now we have locally in driver.
Yes, I agree that makes sense for the constraints.
> I think its matter of assumption, so to conclude our discussion, > please let me know that which approach we should use: > - assume "regulator-ramp-delay = <0>" as ramp_disable. > or > - parsing "regulator_ramp_disable" from DT.
I prefer the first option. [unhandled content-type:application/pgp-signature] | |