Messages in this thread | | | Date | Thu, 04 Jul 2013 10:47:42 -0400 | From | Waiman Long <> | Subject | Re: [PATCH v4 04/12] auto-fs: rename d_count field of dentry to d_refcount |
| |
On 07/03/2013 11:50 PM, Linus Torvalds wrote: > On Wed, Jul 3, 2013 at 8:33 PM, Waiman Long<Waiman.Long@hp.com> wrote: >> Because of the d_count name change made in dcache.h, all references >> to d_count have to be changed to d_refcount. There is no change in >> logic and everything should just work. > These filesystem patches need to be just joined into the same patch > that does the d_count -> d_refcount change. > > Otherwise the kernel won't build in lots of configurations for some > commits, which makes things like bisecting much more painful than it > should be. > > So we can't do piece-meal changes that break the build for parts of the tree. > > Linus
I could change patch 3 so that I keep the d_count name, but #define d_refcount to d_count. In that way, I can do piece-meal changes without breaking the build. Alternatively, I could collapse patches 3-11 into a single big patch which will be harder to review.
Regards, Longman
| |