Messages in this thread | | | Date | Wed, 31 Jul 2013 08:54:51 +0100 | From | Mel Gorman <> | Subject | Re: [PATCH 02/18] sched: Track NUMA hinting faults on per-node basis |
| |
On Mon, Jul 29, 2013 at 12:10:59PM +0200, Peter Zijlstra wrote: > On Mon, Jul 15, 2013 at 04:20:04PM +0100, Mel Gorman wrote: > > +++ b/kernel/sched/fair.c > > @@ -815,7 +815,14 @@ void task_numa_fault(int node, int pages, bool migrated) > > if (!sched_feat_numa(NUMA)) > > return; > > > > - /* FIXME: Allocate task-specific structure for placement policy here */ > > + /* Allocate buffer to track faults on a per-node basis */ > > + if (unlikely(!p->numa_faults)) { > > + int size = sizeof(*p->numa_faults) * nr_node_ids; > > + > > + p->numa_faults = kzalloc(size, GFP_KERNEL); > > We should probably stick a __GFP_NOWARN in there. >
Yes.
-- Mel Gorman SUSE Labs
| |