Messages in this thread | | | Date | Wed, 31 Jul 2013 07:55:27 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 2/2] chipidea: Use devm_request_irq() |
| |
On Wed, Jul 31, 2013 at 12:50:27PM +0100, Mark Brown wrote: > Most things would work just fine - most of the uses of devm_ are just > resource allocations that can safely be freed in essentially any order. > It doesn't really matter if you free the driver's private structure > before you free the clock that's pointing to it or whatever since > neither has any real connection to the other.
If you have DMA / IRQ / command engine deactivations in devm path which often is the case with full conversions, freeing any resources including DMA areas and host private data in the wrong order is a horrible idea. It's worse as it won't really be noticeable in most cases.
Thanks.
-- tejun
| |