Messages in this thread | | | Date | Wed, 31 Jul 2013 06:44:48 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 3/7] cgroup: restructure the failure path in cgroup_write_event_control() |
| |
On Wed, Jul 31, 2013 at 04:17:06PM +0800, Li Zefan wrote: > It uses a single label and checks the validity of each pointer. This > is err-prone, and actually we once had a bug because one of the check > was insufficient. > > Use multi lables as we do in other places. > > Signed-off-by: Li Zefan <lizefan@huawei.com>
Hmm... I usually prefer mix of the two approaches as both extremes tend to be pretty ugly when things get complex. I don't mind the conversion but can you please drop the no longer unnecessary NULL assignments on variable definitions?
Thanks.
-- tejun
| |