lkml.org 
[lkml]   [2013]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH net] virtio-net: fix the race between channels setting and refill
    From
    From: Jason Wang <jasowang@redhat.com>
    Date: Wed, 3 Jul 2013 20:15:52 +0800

    > Commit 55257d72bd1c51f25106350f4983ec19f62ed1fa (virtio-net: fill only rx queues
    > which are being used) tries to refill on demand when changing the number of
    > channels by call try_refill_recv() directly, this may race:
    >
    > - the refill work who may do the refill in the same time
    > - the try_refill_recv() called in bh since napi was not disabled
    >
    > Which may led guest complain during setting channels:
    >
    > virtio_net virtio0: input.1:id 0 is not a head!
    >
    > Solve this issue by scheduling a refill work which can guarantee the
    > serialization of refill.
    >
    > Cc: Sasha Levin <sasha.levin@oracle.com>
    > Cc: Rusty Russell <rusty@rustcorp.com.au>
    > Cc: Michael S. Tsirkin <mst@redhat.com>
    > Signed-off-by: Jason Wang <jasowang@redhat.com>

    Michael, please review.

    Thanks.


    \
     
     \ /
      Last update: 2013-07-04 02:21    [W:3.161 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site