lkml.org 
[lkml]   [2013]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[051/141] iommu/amd: Re-enable IOMMU event log interrupt after handling.
    3.6.11.6 stable review patch.
    If anyone has any objections, please let me know.

    ------------------

    From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>

    [ Upstream commit 925fe08bce38d1ff052fe2209b9e2b8d5fbb7f98 ]

    Current driver does not clear the IOMMU event log interrupt bit
    in the IOMMU status register after processing an interrupt.
    This causes the IOMMU hardware to generate event log interrupt only once.
    This has been observed in both IOMMU v1 and V2 hardware.
    This patch clears the bit by writing 1 to bit 1 of the IOMMU
    status register (MMIO Offset 2020h)

    Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
    Signed-off-by: Joerg Roedel <joro@8bytes.org>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    drivers/iommu/amd_iommu.c | 3 +++
    drivers/iommu/amd_iommu_types.h | 1 +
    2 files changed, 4 insertions(+)

    diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
    index c698cf6..195ec2e 100644
    --- a/drivers/iommu/amd_iommu.c
    +++ b/drivers/iommu/amd_iommu.c
    @@ -601,6 +601,9 @@ static void iommu_poll_events(struct amd_iommu *iommu)
    u32 head, tail;
    unsigned long flags;

    + /* enable event interrupts again */
    + writel(MMIO_STATUS_EVT_INT_MASK, iommu->mmio_base + MMIO_STATUS_OFFSET);
    +
    spin_lock_irqsave(&iommu->lock, flags);

    head = readl(iommu->mmio_base + MMIO_EVT_HEAD_OFFSET);
    diff --git a/drivers/iommu/amd_iommu_types.h b/drivers/iommu/amd_iommu_types.h
    index d0dab86..c6d556c 100644
    --- a/drivers/iommu/amd_iommu_types.h
    +++ b/drivers/iommu/amd_iommu_types.h
    @@ -99,6 +99,7 @@
    #define PASID_MASK 0x000fffff

    /* MMIO status bits */
    +#define MMIO_STATUS_EVT_INT_MASK (1 << 1)
    #define MMIO_STATUS_COM_WAIT_INT_MASK (1 << 2)
    #define MMIO_STATUS_PPR_INT_MASK (1 << 6)

    --
    1.7.10.4



    \
     
     \ /
      Last update: 2013-07-03 21:41    [W:3.152 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site