lkml.org 
[lkml]   [2013]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v2] generic-ipi: kill unnecessary variable - csd_flags
    After commit:8969a5ede0f9e17da4b943712429aef2c9bcd82b
    "generic-ipi: remove kmalloc()", wait = 0 can be guaranteed.

    And all callsites of generic_exec_single() do an unconditional
    csd_lock() now.

    So csd_flags is unnecessary now. Remote it.

    Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: https://patchwork.kernel.org/patch/2834744/
    ---
    kernel/smp.c | 14 +-------------
    1 file changed, 1 insertion(+), 13 deletions(-)

    diff --git a/kernel/smp.c b/kernel/smp.c
    index fe9f773..7332697 100644
    --- a/kernel/smp.c
    +++ b/kernel/smp.c
    @@ -186,25 +186,13 @@ void generic_smp_call_function_single_interrupt(void)

    while (!list_empty(&list)) {
    struct call_single_data *csd;
    - unsigned int csd_flags;

    csd = list_entry(list.next, struct call_single_data, list);
    list_del(&csd->list);

    - /*
    - * 'csd' can be invalid after this call if flags == 0
    - * (when called through generic_exec_single()),
    - * so save them away before making the call:
    - */
    - csd_flags = csd->flags;
    -
    csd->func(csd->info);

    - /*
    - * Unlocked CSDs are valid through generic_exec_single():
    - */
    - if (csd_flags & CSD_FLAG_LOCK)
    - csd_unlock(csd);
    + csd_unlock(csd);
    }
    }

    --
    1.8.2.1



    \
     
     \ /
      Last update: 2013-07-30 05:21    [W:4.942 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site