lkml.org 
[lkml]   [2013]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/8] cgroup: convert cgroup_ida to cgroup_idr
On 2013/7/30 2:28, Tejun Heo wrote:
> Hello,
>
> On Mon, Jul 29, 2013 at 03:07:48PM +0800, Li Zefan wrote:
>> @@ -4590,6 +4599,9 @@ static void cgroup_offline_fn(struct work_struct *work)
>> /* delete this cgroup from parent->children */
>> list_del_rcu(&cgrp->sibling);
>>
>> + if (cgrp->id)
>> + idr_remove(&cgrp->root->cgroup_idr, cgrp->id);
>> +
>
> Yeap, if we're gonna allow lookups, removal should happen here but can
> we please add short comment explaining why that is?

sure

> Also, do we want to clear cgrp->id?
>

Set cgrp->id to 0? No, 0 is a valid id. The if is here because at first
I called idr_alloc() very late in cgroup_create(), so cgroup_offline_fn()
can be called while cgrp->id hasn't been initialized. Now I can remove
this check.



\
 
 \ /
  Last update: 2013-07-30 03:41    [W:0.342 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site