Messages in this thread | | | From | "Winkler, Tomas" <> | Subject | RE: [char-misc-next 2/3] mei: adding sysfs fw_status attribute | Date | Mon, 29 Jul 2013 22:27:06 +0000 |
| |
> > > > > > > > > > > > > > > > > > > > > Just to make sure, is this what you're suggesting ? > > > > > > > > > > > > device->groups = mei_attr_groups > > > > > > mei_misc_device.parent = device; ret = > > > > > > misc_register(&mei_misc_device); > > > > > > > > > > Yes, that should work. If not, please let me know, the code > > > > > underwent some changes in 3.11-rc2. > > > > > > > > I don' t see the file being created. > > > > Not sure if the misc_register setup the parent sysfs as well. > > > > > > Oops, wait, the parent is already registered, that's not going to > > > work, you want to create the files for the device itself that you > > > are creating, so set the - > > > >groups field for that device. > > > > > > sorry about that. > > > > So is this okay to go as is? > > What is "this"?
The intentions was to create the sysfs on a parent pci device, and these are already created . The only reason I wanted do it here as this is true for any parent pci device we support currently that registers with mei.
Either this code ode is still confusing because I'm doing something wrong here or your mind Is set on fixing this particular user space race issue.
Thanks Tomas
| |