Messages in this thread | | | Date | Mon, 29 Jul 2013 23:46:47 +0200 | From | Sylwester Nawrocki <> | Subject | Re: [PATCH] usb: phy-samsung-usb: Simplify PMU register handling |
| |
On 07/29/2013 11:12 PM, Julius Werner wrote: >>> - if (sphy->phy_type == USB_PHY_TYPE_DEVICE) { >>> - reg = sphy->pmuregs + sphy->drv_data->devphy_reg_offset; >>> - en_mask = sphy->drv_data->devphy_en_mask; >>> - } else if (sphy->phy_type == USB_PHY_TYPE_HOST) { >>> - reg = sphy->pmuregs + sphy->drv_data->hostphy_reg_offset; >>> - en_mask = sphy->drv_data->hostphy_en_mask; >>> - } >> >> >> How is en_mask supposed to get initialized, now when this code is removed ? >> It's always 0 now, isn't it ? >> > > Whoops... oh, I'm really sorry about that. I ported the patch from a > branch with slightly different code there and overlooked this. Thanks > for catching it, will send v2 in a minute.
v2 looks good, thanks. :) As a side note, we are working on the USB PHYs driver using the generic PHY framework (actually Kamil is working on that). Thus it is likely the original driver will get replaced in near future by something else. Not sure when that happens exactly but I suspect it is not worth to invest in the Samsung USB PHY drivers at drivers/usb/phy/ too much and introduce changes, especially in *.dts, that won't be for long time in use. Perhaps Kamil can provide more details on which devices are initially going to be covered by the new driver.
-- Thanks, Sylwester
| |