lkml.org 
[lkml]   [2013]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: android: logger..c fixed a brace coding style issue
On Sun, Jul 28, 2013 at 04:47:51PM +0300, abbasjasim wrote:
> fixed a coding style issue.
>
> Signed-off-by: Abbas J. Mohammed <abbasjasim.AJ@gmail.com>
> ---
> drivers/staging/android/logger.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c
> index ffc2d04..3d5180a 100644
> --- a/drivers/staging/android/logger.c
> +++ b/drivers/staging/android/logger.c
> @@ -81,8 +81,9 @@ static inline struct logger_log *file_get_log(struct file *file)
> if (file->f_mode & FMODE_READ) {
> struct logger_reader *reader = file->private_data;
> return reader->log;
> - } else
> + } else {
> return file->private_data;
> + }

I think the existing code is just fine, no need for this patch.

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-07-29 20:41    [W:0.471 / U:1.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site