lkml.org 
[lkml]   [2013]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ATA: sata_mv: Remove uneeded CONFIG_HAVE_CLK ifdefs
On Mon, Jul 29, 2013 at 12:21:22PM -0300, Ezequiel Garcia wrote:
> If CONFIG_HAVE_CLK is not selected, then all the clk API turn out
> into stubs, so there's no need to have the ifdefs.
> The only side-effect of this patch is the extra tiny kmalloc,
> but that's not enough reason to have such ugly ifdefs all around
> the code.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>

Can you please add a comment in the hpriv definition explaining what
that clk is for and how it's optional and becomes noops when not
needed?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-07-29 18:41    [W:0.059 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site