Messages in this thread | | | Date | Mon, 29 Jul 2013 12:00:16 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH] ATA: sata_mv: Remove uneeded CONFIG_HAVE_CLK ifdefs |
| |
On Mon, Jul 29, 2013 at 12:21:22PM -0300, Ezequiel Garcia wrote: > If CONFIG_HAVE_CLK is not selected, then all the clk API turn out > into stubs, so there's no need to have the ifdefs. > The only side-effect of this patch is the extra tiny kmalloc, > but that's not enough reason to have such ugly ifdefs all around > the code. > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Can you please add a comment in the hpriv definition explaining what that clk is for and how it's optional and becomes noops when not needed?
Thanks.
-- tejun
| |