Messages in this thread | | | Date | Mon, 29 Jul 2013 16:21:58 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH v2 6/6] tracing: Change remove_event_file_dir() to clear "d_subdirs"->i_private |
| |
On 07/29, Masami Hiramatsu wrote: > > (2013/07/27 2:25), Oleg Nesterov wrote: > > Change remove_event_file_dir() to clear ->i_private for every > > file we are going to remove. > > Oleg, I think this should be done first. > > AFAICS, your former patches depend strongly on this change. > Without this, they don't work as you expected, and it may > prevent git-bisect.
Why?
v2 specially does this in the last change for bisecting/etc.
1-4 change f_op->read/write to check i_private != NULL but until this final patch i_private == NULL is not possible.
> I see, including this patch also breaks current ftrace.
Could you clarify?
Oleg.
| |