lkml.org 
[lkml]   [2013]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/10] ARM: sunxi: Add Allwinner A31 DTSI
On Tue, Jul 23, 2013 at 11:25:07PM +0100, Maxime Ripard wrote:
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> arch/arm/boot/dts/Makefile | 3 +-
> arch/arm/boot/dts/sun6i-a31.dtsi | 155 +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 157 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/boot/dts/sun6i-a31.dtsi

[...]

> + soc@01c20000 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + reg = <0x01c20000 0x300000>;

That's unnecessary, nothing should be using this for a simple-bus.

> + ranges;
> +
> + timer@01c20c00 {
> + compatible = "allwinner,sun4i-timer";
> + reg = <0x01c20c00 0xa0>;
> + interrupts = <
> + 0 18 1
> + 0 19 1
> + 0 20 1
> + 0 21 1
> + 0 22 1
> + >;

A cosmetic issue, but this would be nicer with each tuple bracketed:

interrupts = <0 18 1>,
<0 19 1>,
<0 20 1>,
<0 21 1>,
<0 22 1>;

> + clocks = <&osc>;
> + };

Thanks,
Mark.


\
 
 \ /
  Last update: 2013-07-29 17:01    [W:0.172 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site