lkml.org 
[lkml]   [2013]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch]workqueue: copy attr with all fields.
On Mon, Jul 29, 2013 at 07:14:01AM -0400, Tejun Heo wrote:
> Hello, Shaohua.
>
> On Mon, Jul 29, 2013 at 02:24:12PM +0800, Shaohua Li wrote:
> > copy_workqueue_attrs() forgets to copy no_numa field.
>
> Explaining how that affects things and how the behavior changes
> afterwards would be nice. As it currently stands, I don't know why
> you're submitting this patch. Is this a bug fix? Just a consistency
> update? Should it be marked with -stable?
>
> Please put more effort into patch descriptions and also note that
> ->no_numa isn't a pool attribute as noted in the comment above struct
> workqueue_attrs definition.

Ah, ok, I thought it's straightforward... It's a bug fix.
echo '0' > /sys/bus/workqueue/devices/xxx/numa
cat /sys/bus/workqueue/devices/xxx/numa
I got 1. It should be 0, the reason is copy_workqueue_attrs() called in
apply_workqueue_attrs() doesn't copy no_numa field.

Thanks,
Shaohua


\
 
 \ /
  Last update: 2013-07-29 15:21    [W:0.076 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site