lkml.org 
[lkml]   [2013]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] staging: gdm724x: use GFP_ATOMIC under spin lock
On Fri, Jul 26, 2013 at 10:15:55AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> A spin lock is taken here so we should use GFP_ATOMIC.
>

Acked-by: Dan Carpenter <dan.carpenter@oracle.com>

But the locking here is really odd and pointless. usb_submit_urb()
returns asynchronously before the data has been sent, so there is
almost no point in locking around it.

regards,
dan carpenter



\
 
 \ /
  Last update: 2013-07-26 10:01    [W:0.051 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site