Messages in this thread | | | Date | Fri, 26 Jul 2013 10:32:33 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH -next] staging: gdm724x: use GFP_ATOMIC under spin lock |
| |
On Fri, Jul 26, 2013 at 10:15:55AM +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > A spin lock is taken here so we should use GFP_ATOMIC. >
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
But the locking here is really odd and pointless. usb_submit_urb() returns asynchronously before the data has been sent, so there is almost no point in locking around it.
regards, dan carpenter
| |