lkml.org 
[lkml]   [2013]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] ALSA: Added jack detection kcontrol support
    On Fri, Jul 26, 2013 at 11:25:30AM -0700, Felipe F. Tonello wrote:

    > +
    > + /* Update ALSA KControl interface */
    > + snd_kctl_jack_report((struct snd_card *)jack->kctl->private_data, jack->kctl, !!status);

    This isn't ideal for multi-function jacks like headsets - it will report
    a single boolean value for the jack regardless of what's plugged in
    meaning userpace can't do things like figure out if a headset or
    headphone is present. It's probably OK for any realistic input button
    since you're not going to get an input button without other things being
    present.

    What I'd expect to happen here is that for multi function jacks we
    create a control per function if the controls are valid.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2013-07-26 21:21    [W:8.944 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site