Messages in this thread | | | Date | Fri, 26 Jul 2013 19:46:44 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/4] ALSA: Added jack detection kcontrol support |
| |
On Fri, Jul 26, 2013 at 11:25:30AM -0700, Felipe F. Tonello wrote:
> - snprintf(kctl->id.name, sizeof(kctl->id.name), "%s Jack", name); > + > + strlcpy(kctl->id.name, name, sizeof(kctl->id.name));
This looks like it'd break existing users unless they are updated to remove the "Jack" from their calls?
> * @type: a bitmask of enum snd_jack_type values that can be detected by > * this jack > + * @idx: index of this control item > * @jjack: Used to provide the allocated jack object to the caller.
"The index of the ALSA control created to represent the jack. [unhandled content-type:application/pgp-signature] | |