Messages in this thread | | | Date | Thu, 25 Jul 2013 16:43:57 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: PATCH? debugfs_remove_recursive() must not rely on list_empty(d_subdirs) |
| |
On Thu, Jul 25, 2013 at 10:04:23PM +0200, Oleg Nesterov wrote: > On 07/25, Oleg Nesterov wrote: > > > > To simplify the review, this is how it looks with the patch applied: > > v2. We can use simply use list_for_each_entry_safe() and > list_next_entry() should be calles under ->i_mutex. Although > debugfs_remove_recursive() can race with itself anyway, but > still. > > And the code looks much simpler. But I do not know what did > I miss.
debugfs has a number of known issues with removing files / directories. Al has helpfully pointed them out to me, and it's on my list of things to fix, but it keeps getting pushed down by other things. Hopefully in a few weeks...
Anyway, your changes below look good in this version, I don't see anything obviously wrong with it, but maybe others do?
Care to turn this version into a patch I can test out?
thanks,
greg k-h
| |