lkml.org 
[lkml]   [2013]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2] bridge: disable snooping if there is no querier
On Thu, 25 Jul 2013 15:56:20 +0200
Linus Lüssing <linus.luessing@web.de> wrote:

>
> +static void br_multicast_update_querier_timer(struct net_bridge *br,
> + unsigned long max_delay)
> +{
> + if (!timer_pending(&br->multicast_querier_timer))
> + atomic64_set(&br->multicast_querier_delay_time,
> + jiffies + max_delay);
> +
> + mod_timer(&br->multicast_querier_timer,
> + jiffies + br->multicast_querier_interval);
> +}
> +

Isn't this test racing with timer expiration.

static void br_multicast_update_querier_timer(struct net_bridge *br,
unsigned long max_delay)
{
if (!timer_pending(&br->multicast_querier_timer))
atomic64_set(&br->multicast_querier_delay_time,
jiffies + max_delay);
What if timer completes here?

mod_timer(&br->multicast_querier_timer,
jiffies + br->multicast_querier_interval);
}


And another race if timer goes off?

static void br_multicast_update_querier_timer(struct net_bridge *br,
unsigned long max_delay)
{
if (!timer_pending(&br->multicast_querier_timer))
atomic64_set(&br->multicast_querier_delay_time,
jiffies + max_delay);
Timer fires here...?

mod_timer(&br->multicast_querier_timer,
jiffies + br->multicast_querier_interval);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-07-25 18:21    [W:0.113 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site