Messages in this thread | | | Date | Thu, 25 Jul 2013 09:04:43 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver. |
| |
On Wed, 24 Jul 2013, Philipp Zabel wrote:
> From: Krystian Garbaciak <krystian.garbaciak@diasemi.com> > > This is MFD module providing access to registers and interrupts of DA906x > series PMIC. It is used by other functional modules, registered as MFD cells. > Driver uses regmap with paging to access extended register list. Register map > is divided into two pages, where the second page is used during initialisation. > > This module provides support to following functional cells: > - Regulators > - RTC > - HWMON > - OnKey (power key misc input device) > - Vibration (force-feedback input device) > - Watchdog > - LEDs > > Signed-off-by: Krystian Garbaciak <krystian.garbaciak@diasemi.com> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > --- > drivers/mfd/Kconfig | 12 + > drivers/mfd/Makefile | 3 + > drivers/mfd/da9063-core.c | 177 ++++++ > drivers/mfd/da9063-i2c.c | 197 ++++++ > drivers/mfd/da9063-irq.c | 193 ++++++ > include/linux/mfd/da9063/core.h | 110 ++++ > include/linux/mfd/da9063/pdata.h | 114 ++++ > include/linux/mfd/da9063/registers.h | 1090 ++++++++++++++++++++++++++++++++++ > 8 files changed, 1896 insertions(+)
Whoah!! Who's going to want to review a 2k line patch?
Any chance you can split this stuff up into more 'bite sized' patches?
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |