lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH-RESEND 3/3] staging/lustre: fix Kconfig bool defaults
On Thu, Jul 25, 2013 at 4:07 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Thu, Jul 25, 2013 at 02:08:19AM +0800, Peng Tao wrote:
>> From: Peng Tao <tao.peng@emc.com>
>>
>> Should be y instead of true.
>>
>> Reported-by: Paul Bolle <pebolle@tiscali.nl>
>> Cc: Andreas Dilger <andreas.dilger@intel.com>
>> Signed-off-by: Peng Tao <tao.peng@emc.com>
>> ---
>> drivers/staging/lustre/lustre/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
>> index 9ae7fa8..e3b3c74 100644
>> --- a/drivers/staging/lustre/lustre/Kconfig
>> +++ b/drivers/staging/lustre/lustre/Kconfig
>> @@ -52,4 +52,4 @@ config LUSTRE_DEBUG_EXPENSIVE_CHECK
>> config LUSTRE_TRANSLATE_ERRNOS
>> bool
>> depends on LUSTRE_FS && !X86
>> - default true
>> + default y
>
> Why is the default for this going to be 'y'? That should only be for
> things that keep the machine from booting.
>
> If this is something you always want to do, then why make it an option
> at all?
>
> Given that there is no documentation for what this option is, and why
> people should always turn it on, I can't accept this patch, sorry.
>
I was hoping to use the config option to control over whether the
translation code need to be compiled. After checking other Makefiles,
I found that I can just use ifeq clause in Makefile to do it. So this
config option can be deleted. I will send updated patch.

Thanks,
Tao


\
 
 \ /
  Last update: 2013-07-25 05:01    [W:0.051 / U:1.552 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site